-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Status indicator] Update Status indicator pattern guidance #4309
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, awesome work Thy! I left a few formatting suggestions here in the PR and also some other general comments and questions over in Figma.
There are at least four possible ways to implement status indicators: | ||
Status indicators have been paired with specific type sizes that work best in | ||
products. While shape indicators can be paired with a larger size, it’s | ||
recommended to use 14pt or 12pt in smaller spaces or when used as a secondary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be px instead of pt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM other than one comment around using px instead of pt when referring to font sizes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small things still
@@ -509,8 +516,8 @@ our system. | |||
#### Color | |||
|
|||
Differential indicators are either displaying a positive or a negative value. | |||
Color is optional in these situations as long as the value has either a ‘+’ or | |||
‘-’ in front of it, a chevron icon, or an arrow icon. Unless the data involves | |||
Color is optional in these situations as long as the value has either a "+" or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
<StatusIndicatorTable attention="high" /> | ||
If your product needs an icon that’s not currently included, please reach out to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say open an issue instead here and link them to the correct repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to say the same thing! Just so people know where to go if they need to contact us or to submit an icon
started, and purple indicates outliers or undefined statuses. | ||
information and workflow progress. This status color palette also includes gray | ||
and purple to add more depth to the system. Gray indicates drafts or jobs that | ||
haven’t been started, and purple indicates outliers or undefined statuses. | ||
|
||
<ColorPalette twoColumn type="status" /> | ||
|
||
#### Extended status palettes | ||
|
||
This palette is only for added contrast accessibility when using yellows and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still say these colors are not part of the brand palette and should not be used in other contexts.
Alina's feedback: An image will help improve this context Taylor's feedback
Slight difference there is for the inputs we always set background-color: $field; whereas with standalone status icons we won't know/control what background they're placed on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great, @thyhmdo ! Just a couple of minor things. Great work! ⭐️
- The square border around the icons/symbols should be
Magenta 60
to match the line that connects to it.
- This image under the Shape indicator section needs to be updated to show the correct colors for the indicators in the data table. Right now they all look orange.
- I think this column header for this section should say "Shape" instead of "Icon"?
- I noticed that in the Shape indicator table you use slashes to separate different tokens per shape, but in the Icon indicator table you use commas. I would just pick one approach for consistency, maybe just use the comma?
|
||
| Variant | Usage | Use cases | | ||
| ---------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------- | | ||
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets | | |
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color, and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets | |
| Variant | Usage | Use cases | | ||
| ---------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------- | | ||
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets | | ||
| [Shape indicator](#shape-indicator) | Useful in smaller spaces or when users need to scan large amount of data. | Most often used in lists, dashboards, data tables, data visualizations, and network diagrams | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Shape indicator](#shape-indicator) | Useful in smaller spaces or when users need to scan large amount of data. | Most often used in lists, dashboards, data tables, data visualizations, and network diagrams | | |
| [Shape indicator](#shape-indicator) | Useful in smaller spaces or when users need to scan large amounts of data. | Most often used in lists, dashboards, data tables, data visualizations, and network diagrams | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just double check the use of periods in the Usage and Use cases columns for all of the descriptions. There should be periods after complete sentences.
| ---------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------- | | ||
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets | | ||
| [Shape indicator](#shape-indicator) | Useful in smaller spaces or when users need to scan large amount of data. | Most often used in lists, dashboards, data tables, data visualizations, and network diagrams | | ||
| [Badge indicator (with number)](#badge-indicator) | Useful when a count of new or updated items is available, and it is important for the user to know the number of updates. | Most often used in notification panes in the header, and used in conjunction with avatars or icons | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Badge indicator (with number)](#badge-indicator) | Useful when a count of new or updated items is available, and it is important for the user to know the number of updates. | Most often used in notification panes in the header, and used in conjunction with avatars or icons | | |
| [Badge indicator (with number)](#badge-indicator) | Useful when a count of new or updated items is available, and it is important for the user to know the number of updates. | Most often used in notification panes in the header and used in conjunction with avatars or icons | |
|
||
<StatusIndicatorTable attention="high" /> | ||
If your product needs an icon that’s not currently included, please reach out to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to say the same thing! Just so people know where to go if they need to contact us or to submit an icon
Icons are visual symbols that represent ideas, objects, or actions. They help | ||
communicate messages quickly, encourage interactivity, and highlight important | ||
information—like exclamation points for warnings, checkmarks for success, and | ||
question marks for help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question marks for help | |
question marks for help. |
|
||
![Four icons with badges that included numbers ranging from one to three digits. The last badge has a plus.](./images/status-badge-with-number.png) | ||
|
||
<Caption>Badges with numbers range from one to three digits</Caption> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Caption>Badges with numbers range from one to three digits</Caption> | |
<Caption>Badges with numbers ranging from one to three digits</Caption> |
to the user. This dot badge is more subtle than the numbered badge but still | ||
effectively draws the user’s attention to the icon button. | ||
|
||
The badge without number is commonly seen in toolbars' icon buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The badge without number is commonly seen in toolbars' icon buttons. | |
The badge without a number is commonly seen in toolbars' icon buttons. |
with color vision deficiencies (refer to | ||
[Use of Color](https://www.w3.org/WAI/WCAG22/Understanding/use-of-color.html)). | ||
While color can be useful, it must be paired with text or other visual cues. To | ||
meet accessibility standards, and to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meet accessibility standards, and to pass | |
meet accessibility standards and to pass |
|
||
![Example of accessible status indicators](images/status_indicator_17.png) | ||
Using symbols alone is acceptable, as long as they meet non-text contrast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using symbols alone is acceptable, as long as they meet non-text contrast | |
Using symbols alone is acceptable as long as they meet non-text contrast |
|
||
#### Users should be able to manage or limit non-critical notifications. | ||
<Caption> | ||
Example shows the icon indicators do not need outlines while icon indicators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example shows the icon indicators do not need outlines while icon indicators | |
Example shows the icon indicators do not need outlines, while icon indicators |
Closes ##4272 and #4050
Figma file review: https://www.figma.com/design/EqKmxlJmBiEB4yPBKpGlrZ/Status-Indicator-(Pattern)?node-id=1-1365
New
Changelog